Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-47: Fix API key frame label not covering full screen #59

Merged
merged 5 commits into from
Jun 25, 2024
Merged

GH-47: Fix API key frame label not covering full screen #59

merged 5 commits into from
Jun 25, 2024

Conversation

Owen-Griffin
Copy link
Collaborator

@Owen-Griffin Owen-Griffin commented Jun 25, 2024 •
edited by wos-manager bot
Loading

@wos-manager wos-manager bot mentioned this pull request Jun 25, 2024
Closed
3 tasks
@Owen-Griffin Owen-Griffin requested a review from ItsNeil17 June 25, 2024 19:00
@ItsNeil17 ItsNeil17 changed the title GH-47: Fix API key frame label not covering full screen, and formating via ruff GH-47: Fix API key frame label not covering full screen Jun 25, 2024
ItsNeil17
ItsNeil17 requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ItsNeil17 ItsNeil17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase from main as data is updated without initializing a new frame. please merge

@wos-manager
Copy link

wos-manager bot commented Jun 25, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

ItsNeil17
ItsNeil17 reviewed Jun 25, 2024
View reviewed changes
gui/frames/construction.py Outdated

frame = ConstructionFrame(self.parent)
self.parent.change_frame(frame) # TODO instead of initialising a new frame, update the current frame
self.parent.change_frame(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right here

ItsNeil17
ItsNeil17 previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ItsNeil17 ItsNeil17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ItsNeil17 ItsNeil17 assigned ItsNeil17 and Owen-Griffin and unassigned ItsNeil17 Jun 25, 2024
@ItsNeil17 ItsNeil17 added this to the v0.2.0-beta1 milestone Jun 25, 2024
@ItsNeil17
Copy link
Member

Please lint & merge

@Owen-Griffin Owen-Griffin requested a review from ItsNeil17 June 25, 2024 19:20
ItsNeil17
ItsNeil17 previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@ItsNeil17 ItsNeil17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Owen-Griffin Owen-Griffin requested a review from ItsNeil17 June 25, 2024 20:02
@ItsNeil17 ItsNeil17 merged commit 0c2e45a into main Jun 25, 2024
7 checks passed
@ItsNeil17 ItsNeil17 deleted the bug/GH-47/api-frame-label branch June 25, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsNeil17 ItsNeil17 ItsNeil17 approved these changes

Assignees

@Owen-Griffin Owen-Griffin

Labels
None yet
Projects
None yet
Milestone
v0.2.0-beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@Owen-Griffin @ItsNeil17